Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional features extending defaults in multi-site #1191

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jun 21, 2022

PR Type

[x] Feature

What Is the Current Behavior?

Using multi-site deployments, if you have a default feature list in the brand-specific environment.ts file, and on certain channels - but not all - you want to go live with another feature, it is currently required to repeat the whole feature list for all of those channels.

What Is the New Behavior?

New property addFeatures in multi-site config, that allows adding additional features that extend the feature list for the specific channel.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#77608

@dhhyi dhhyi added enhancement Enhancement to an existing feature community Community contributions labels Jun 21, 2022
@dhhyi dhhyi self-assigned this Jun 21, 2022
@dhhyi dhhyi marked this pull request as ready for review June 21, 2022 15:35
@dhhyi dhhyi removed their assignment Jun 21, 2022
@MaxKless MaxKless self-requested a review June 27, 2022 12:30
@MaxKless MaxKless self-assigned this Jun 27, 2022
@MaxKless MaxKless force-pushed the feat/additional-features-multi-site branch from e9d3e47 to 6cbe371 Compare July 19, 2022 14:38
@MaxKless MaxKless merged commit 8a260b1 into develop Jul 19, 2022
@MaxKless MaxKless deleted the feat/additional-features-multi-site branch July 19, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants