Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing preferred language in user profile #120

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

suschneider
Copy link
Collaborator

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

There is a profile setting for users that supposedly can set the preferred language. However, this setting cannot be set because the REST API is missing for that.

What Is the New Behavior?

The preferred language setting is removed in the users profile settings.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@suschneider suschneider added the bug Something isn't working label Feb 19, 2020
@suschneider suschneider added this to the 0.18 milestone Feb 19, 2020
@suschneider suschneider self-assigned this Feb 19, 2020
@suschneider suschneider changed the title removes changing the preferred language in the user profile fix: removes the preferred language in the user profile Feb 19, 2020
@suschneider suschneider changed the title fix: removes the preferred language in the user profile fix: removing the preferred language in the user profile Feb 19, 2020
@suschneider suschneider changed the title fix: removing the preferred language in the user profile fix: removing preferred language in user profile Feb 19, 2020
@SGrueber
Copy link
Collaborator

remove registration-personal-form component
in registration-form component change comment toDo only birthday

@SGrueber
Copy link
Collaborator

pls remove also select-language compoent

@suschneider suschneider force-pushed the bugfix/remove-preferred-language-from-profile branch from 7b64a8d to 2a1c4c1 Compare February 26, 2020 09:12
@suschneider suschneider force-pushed the bugfix/remove-preferred-language-from-profile branch from 2a1c4c1 to 7dcd588 Compare February 26, 2020 09:32
@suschneider
Copy link
Collaborator Author

Components 'registration-personal-form' and 'select-language' are removed.

@suschneider suschneider merged commit 9f44cff into develop Feb 26, 2020
@suschneider suschneider deleted the bugfix/remove-preferred-language-from-profile branch February 26, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants