Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invite page in ssr is not working #1200

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Conversation

jometzner
Copy link
Collaborator

@jometzner jometzner commented Jun 29, 2022

PR Type

[ X ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

When /invite route is being rendered in SSR context, the identity provider instance is missing a function object leading to errors later on.

When forgotPasword/updatePassword route is being rendered in SSR context, the system shows the Change Password page no matter what identity provider type is configured.

Issue Number: Closes #933

What Is the New Behavior?

See documentation sso.md

Does this PR Introduce a Breaking Change?

[ ] Yes
[ X ] No

Other Information

AB#77778

@jometzner jometzner changed the title Fix/invite page in ssr fix: Invite page in ssr is not working Jun 30, 2022
Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!! 👍

@shauke shauke added this to the 3.0 milestone Jul 14, 2022
@jometzner jometzner merged commit 215525e into develop Jul 14, 2022
@jometzner jometzner deleted the fix/invite-page-in-ssr branch July 14, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Invitation E-mail refers to incorrect URL so that password update is not possible
3 participants