Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add landing page for confirmation data request #1214

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

rowiish
Copy link

@rowiish rowiish commented Jul 15, 2022

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

No handling for confirming a GDPR personal data request available.

Issue Number: Closes #76539

What Is the New Behavior?

Provides a landing page used by the GDPR request for requesting personal data email to confirm that the request was initiated by the user.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

Functionality requires ICM 7.10.38.13-LTS or higher

AB#78231

@rowiish rowiish self-assigned this Jul 15, 2022
@rowiish rowiish requested a review from SGrueber July 15, 2022 09:59
@rowiish rowiish added this to the 3.0 milestone Jul 15, 2022
@rowiish rowiish added the feature New feature or request label Jul 15, 2022
@rowiish rowiish force-pushed the fix/add-landing-page-for-confirmation-data-request branch from 4424d1e to ff65850 Compare July 15, 2022 11:28
@MaxKless MaxKless force-pushed the fix/add-landing-page-for-confirmation-data-request branch from ff65850 to adb46de Compare July 20, 2022 13:07
@shauke shauke assigned SGrueber and rowiish and unassigned rowiish Jul 20, 2022
@skoch-intershop skoch-intershop force-pushed the fix/add-landing-page-for-confirmation-data-request branch 6 times, most recently from 05e22fc to 25ea52a Compare July 29, 2022 09:01
@shauke shauke modified the milestones: 3.0, 3.1 Aug 1, 2022
src/app/core/facades/account.facade.ts Outdated Show resolved Hide resolved
src/app/pages/gdpr/gdpr-page.module.ts Outdated Show resolved Hide resolved
src/assets/i18n/en_US.json Outdated Show resolved Hide resolved
src/assets/i18n/en_US.json Outdated Show resolved Hide resolved
src/assets/i18n/en_US.json Outdated Show resolved Hide resolved
src/assets/i18n/en_US.json Outdated Show resolved Hide resolved
@skoch-intershop skoch-intershop force-pushed the fix/add-landing-page-for-confirmation-data-request branch 5 times, most recently from ea748a6 to 2e451e0 Compare August 17, 2022 11:10
@SGrueber SGrueber marked this pull request as ready for review August 18, 2022 11:19
@SGrueber SGrueber requested a review from mglatter August 19, 2022 06:40
@SGrueber SGrueber assigned mglatter and skoch-intershop and unassigned rowiish Aug 22, 2022
Copy link
Collaborator

@SGrueber SGrueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add route '/gdpr-requests' in the server.ts under disallow for robots to prevent access by search engines

@SGrueber SGrueber force-pushed the fix/add-landing-page-for-confirmation-data-request branch from 831f39d to e0b8613 Compare September 19, 2022 09:11
@SGrueber SGrueber requested review from SGrueber and shauke and removed request for mglatter September 19, 2022 09:13
SGrueber
SGrueber previously approved these changes Sep 19, 2022
@SGrueber SGrueber requested review from shauke and removed request for shauke September 19, 2022 09:14
@shauke shauke force-pushed the fix/add-landing-page-for-confirmation-data-request branch from a83e5f3 to 2ff9aec Compare October 16, 2022 21:56
@shauke shauke requested a review from SGrueber October 17, 2022 06:58
SGrueber
SGrueber previously approved these changes Oct 17, 2022
shauke
shauke previously approved these changes Oct 17, 2022
* landing page for GDPR data request confirmation

REQUIRED ICM VERSION: 7.10.38.14-LTS

Co-authored-by: Silke <s.grueber@intershop.de>
Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
@shauke shauke dismissed stale reviews from SGrueber and themself via 014c594 October 17, 2022 11:30
@shauke shauke force-pushed the fix/add-landing-page-for-confirmation-data-request branch from 91e3ab1 to 014c594 Compare October 17, 2022 11:30
@shauke shauke merged commit b8ba675 into develop Oct 17, 2022
@shauke shauke deleted the fix/add-landing-page-for-confirmation-data-request branch October 17, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants