-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add landing page for confirmation data request #1214
Merged
shauke
merged 1 commit into
develop
from
fix/add-landing-page-for-confirmation-data-request
Oct 17, 2022
Merged
feat: add landing page for confirmation data request #1214
shauke
merged 1 commit into
develop
from
fix/add-landing-page-for-confirmation-data-request
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowiish
force-pushed
the
fix/add-landing-page-for-confirmation-data-request
branch
from
July 15, 2022 11:28
4424d1e
to
ff65850
Compare
MaxKless
force-pushed
the
fix/add-landing-page-for-confirmation-data-request
branch
from
July 20, 2022 13:07
ff65850
to
adb46de
Compare
skoch-intershop
force-pushed
the
fix/add-landing-page-for-confirmation-data-request
branch
6 times, most recently
from
July 29, 2022 09:01
05e22fc
to
25ea52a
Compare
SGrueber
requested changes
Aug 8, 2022
src/app/core/store/general/gdpr-data-request/gdpr-data-request.reducer.ts
Outdated
Show resolved
Hide resolved
src/app/core/models/gdpr-data-request/gdpr-data-request.interface.ts
Outdated
Show resolved
Hide resolved
src/app/core/models/gdpr-data-request/gdpr-data-request.mapper.spec.ts
Outdated
Show resolved
Hide resolved
src/app/core/models/gdpr-data-request/gdpr-data-request.interface.ts
Outdated
Show resolved
Hide resolved
skoch-intershop
force-pushed
the
fix/add-landing-page-for-confirmation-data-request
branch
5 times, most recently
from
August 17, 2022 11:10
ea748a6
to
2e451e0
Compare
SGrueber
approved these changes
Aug 19, 2022
shauke
requested changes
Aug 31, 2022
src/app/pages/gdpr/gdpr-data-request/gdpr-data-request.component.html
Outdated
Show resolved
Hide resolved
src/app/pages/gdpr/gdpr-data-request/gdpr-data-request.component.html
Outdated
Show resolved
Hide resolved
SGrueber
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add route '/gdpr-requests' in the server.ts under disallow for robots to prevent access by search engines
martinstockmann
added a commit
that referenced
this pull request
Sep 13, 2022
SGrueber
pushed a commit
that referenced
this pull request
Sep 19, 2022
SGrueber
force-pushed
the
fix/add-landing-page-for-confirmation-data-request
branch
from
September 19, 2022 09:11
831f39d
to
e0b8613
Compare
SGrueber
requested review from
SGrueber and
shauke
and removed request for
mglatter
September 19, 2022 09:13
SGrueber
previously approved these changes
Sep 19, 2022
shauke
pushed a commit
that referenced
this pull request
Oct 12, 2022
shauke
pushed a commit
that referenced
this pull request
Oct 16, 2022
shauke
force-pushed
the
fix/add-landing-page-for-confirmation-data-request
branch
from
October 16, 2022 21:56
a83e5f3
to
2ff9aec
Compare
SGrueber
previously approved these changes
Oct 17, 2022
shauke
previously approved these changes
Oct 17, 2022
* landing page for GDPR data request confirmation REQUIRED ICM VERSION: 7.10.38.14-LTS Co-authored-by: Silke <s.grueber@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
fix/add-landing-page-for-confirmation-data-request
branch
from
October 17, 2022 11:30
91e3ab1
to
014c594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
No handling for confirming a GDPR personal data request available.
Issue Number: Closes #76539
What Is the New Behavior?
Provides a landing page used by the GDPR request for requesting personal data email to confirm that the request was initiated by the user.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Functionality requires ICM 7.10.38.13-LTS or higher
AB#78231