feat: design preview support #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jometzner
force-pushed
the
feature/design_preview
branch
from
d0d355f
to
878146a
Compare
|
|
|
Waiting for an ICM release that contains the necessary changes on ICM side for the Design Preview for the headless application type. |
jometzner
force-pushed
the
feature/design_preview
branch
from
a6cf5f5
to
4a6b98c
Compare
jometzner
force-pushed
the
feature/design_preview
branch
from
4a6b98c
to
6743f02
Compare
Eisie96
suggested changes
Nov 16, 2022
|
Requires ICM 7.10.39.1 once it is GA. |
Eisie96
force-pushed
the
feature/design_preview
branch
from
6743f02
to
353c039
Compare
|
Azure Demo Servers are available: |
1 similar comment
|
Azure Demo Servers are available: |
* needs to stay http as long as the used ICM is configured with http since it has no valid certificate This reverts commit 3b48c0f.
shauke
added a commit
that referenced
this pull request
Jan 16, 2023
* PreviewContextID interceptor adds PreviewContextID to REST calls
* PreviewService for PreviewContextID handling (set, update, delete)
* changed `{ path: '', redirectTo: 'home', pathMatch: 'full' }` to prevent PreviewContextID query parameter is removed on redirect for empty route path
* documentation (NOT full Design View)
Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de>
shauke
force-pushed
the
feature/design_preview
branch
from
26b22d9
to
694a338
Compare
marschmidt89
previously approved these changes
Jan 16, 2023
* PreviewContextID interceptor adds PreviewContextID to REST calls
* PreviewService for PreviewContextID handling (set, update, delete)
* changed `{ path: '', redirectTo: 'home', pathMatch: 'full' }` to prevent PreviewContextID query parameter is removed on redirect for empty route path
* documentation (NOT full Design View)
Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de>
shauke
force-pushed
the
feature/design_preview
branch
from
d0a6f4b
to
5c73145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the New Behavior?
Initial Design Preview support (!!! NOT Design View with editing capabilities !!!)
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#78271