Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent linting for running schematics with dry-run option #1226

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

suschneider
Copy link
Collaborator

@suschneider suschneider commented Jul 26, 2022

PR Type

[x] Bugfix

What Is the Current Behavior?

Issue Number: Closes #1221

Running intershop schematics with the --dry-run option results in errors because of the appended prettier check that fails for non existing files.

What Is the New Behavior?

Prevent the additional formatting checks with prettier for dry runs so no errors occur.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

AB#78477

@suschneider suschneider added this to the 3.0 milestone Jul 26, 2022
@suschneider suschneider self-assigned this Jul 26, 2022
@suschneider suschneider merged commit 5183ed4 into develop Aug 1, 2022
@suschneider suschneider deleted the fix/schematics-with-dry-run branch August 1, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schematics with '--dry-run' option result in error
2 participants