fix: unnecessary emissions of the getCurrentBasket selector if the ba… #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sket loading state changes
MaxKless
approved these changes
Aug 4, 2022
clindeIntershop
pushed a commit
that referenced
this pull request
Aug 11, 2022
fix: unnecessary emissions of the getCurrentBasket selector if the basket loading state changes Co-authored-by: Danilo Hoffmann dhhyi@aol.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sket loading state changes
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
If the basket loading state changes the getCurrentBasket selector always emits a value even if the basket doesn't change. This leads, inter alia, to a further rendering of the basket item list after a basket item quantity has been changed, a basket item has been deleted or maybe other actions like assigning a cost center to basket and so on.
After entering a basket item quantity on basket page the original quantity is displayed shortly during the basket update (loading).
Issue Number: Closes #
What Is the New Behavior?
The getCurrentBasket item only emits a value if the basket object, the basket validation or info changes but not if the loading state changes.
After updating a basket item quantity on basket page the entered quantity remains in the input field.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#78637