feat: show system reject errors for requisition #1238
Conversation
| @@ -51,6 +51,7 @@ export class RequisitionMapper { | |||
| }, | |||
| }, | |||
| systemRejected: data.systemRejected, | |||
| systemRejectErrors: data.systemRejectErrors?.map(message => message.message), | |||
There was a problem hiding this comment.
Because the message is an optional field, does it make sense to map the code here if the message is missing?
Otherwise you could remove the code from the interface if you never use it
src/assets/i18n/en_US.json
Outdated
| @@ -530,7 +530,7 @@ | |||
| "approval.detailspage.approval.heading": "Approval Details", | |||
| "approval.detailspage.approval_date.label": "Date of Approval", | |||
| "approval.detailspage.approval_status.label": "Approval Status", | |||
| "approval.detailspage.approval_status.system_rejected.comment": "The order could not be placed because the requisition was invalid.", | |||
| "approval.detailspage.approval_status.system_rejected.comment": "The order could not be placed because the requisition was invalid. This is caused by the following reason(s):", | |||
There was a problem hiding this comment.
Use num plural here like: {{ num, plural, =0{} =1{This is caused by the following reason:} other{This is caused by the following reasons:} }}
I hope it will work - I haven't checked it out
Pls change also the German and French translation or ask Mandy to do it.
DiverDori
force-pushed
the
feature/show_systemreject_errors_for_requisitions
branch
from
3108403
to
b302224
Compare
| <p>{{ 'approval.detailspage.approval_status.system_rejected.comment' | translate }}</p> | ||
| <p> | ||
| {{ 'approval.detailspage.approval_status.system_rejected.comment' | translate }} | ||
| <ng-container *ngIf="requisition.systemRejectErrors"> |
There was a problem hiding this comment.
requisition.systemRejectErrors?.length
| <ng-container *ngIf="requisition.systemRejectErrors"> | ||
| {{ | ||
| 'approval.detailspage.approval_status.system_rejected.reasons.comment' | ||
| | translate: { '0': requisition.systemRejectErrors?.length ?? 0 } |
There was a problem hiding this comment.
{ '0': requisition.systemRejectErrors.length }
DiverDori
force-pushed
the
feature/show_systemreject_errors_for_requisitions
branch
from
b302224
to
34773c6
Compare
|
PR will be merged as soon as the missing translations have been added. |
PR Type
[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Requisitions that have been system rejected do not show the reject reasons.
Issue Number: Closes #
What Is the New Behavior?
System reject reasons are now delivered via REST API and will be shown.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x] No
Other Information
AB#78718