fix: prevent directory traversal on SSR #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X] Bugfix
What Is the Current Behavior?
It is possible to get file contents from the underlying container files system by passing a relative file system path behind any
.jsor.cssresource url (valid for PWA 1.0 to 2.1.0).For example:
https://host/.js?/../../../../etc/hosts would potentially leak the contents of file
/etc/hostsWhat Is the New Behavior?
You'll get a 404 when trying to breakout of the server determined
BROWSER_FOLDER.(This is already fixed with 2.1.0 but this fix adds an additional check to prevent the unwanted behavior)
Does this PR Introduce a Breaking Change?
[X] No
Other Information
https://nodejs.org/en/knowledge/file-system/security/introduction/#preventing-directory-traversal
AB#78766