fix: respect navigation root when displaying the breadcrumb of cms pages #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
bugfix/cms_breadcrumb
branch
from
83c60d0 to
b39d0c7
Compare
shauke
reviewed
Aug 19, 2022
src/app/shared/cms/components/cms-static-page/cms-static-page.component.html
Outdated
Show resolved
Hide resolved
SGrueber
force-pushed
the
bugfix/cms_breadcrumb
branch
from
b39d0c7 to
8a1bc4c
Compare
shauke
force-pushed
the
bugfix/cms_breadcrumb
branch
2 times, most recently
from
3a9c8f2 to
7e18ffe
Compare
shauke
added a commit
that referenced
this pull request
Sep 26, 2022
…e Component (#1250) * needed to respect navigation root when displaying the breadcrumb of cms pages
shauke
force-pushed
the
bugfix/cms_breadcrumb
branch
from
7e18ffe to
1dd740f
Compare
…e Component (#1250) * needed to respect navigation root when displaying the breadcrumb of cms pages
shauke
force-pushed
the
bugfix/cms_breadcrumb
branch
from
1dd740f to
19764be
Compare
Eisie96
previously approved these changes
Oct 4, 2022
jometzner
pushed a commit
that referenced
this pull request
Oct 5, 2022
…e Component (#1250) * needed to respect navigation root when displaying the breadcrumb of CMS pages Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
The breadcrumb of cms pages contains always the whole path of the page tree even if a deferring navigation root is defined.
What Is the New Behavior?
The display of the cms breadcrumb respects the defined navigation root.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#78918