Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display variation products if a non-matching product filter has previously been set #1252

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Aug 19, 2022

PR Type

[x] Bugfix

What Is the Current Behavior?

After applying a product filter and switching to a master product via the "Recently viewed" section, the product variants of the master product are no longer displayed if they do not match the filter.

What Is the New Behavior?

The variation products are shown as expected.

Does this PR Introduce a Breaking Change?

[x] Yes

Other Information

Steps to repeat:
Precondition: Advanced variation handling (List View) is checked in the channel preference of the ICM back office.

  1. Navigate to a master product (e.g. "Microsoft Surface Laptop") (The variation products should be displayed in a list below the product description).
  2. Navigate to a category page where filters are displayed in the navigation.
  3. Select a filter (e.g. Brand = "A-Data") and open a product.
  4. Go to the "Recently viewed" section and open the master product again (the variation products are no longer displayed).

AB#78939

@SGrueber SGrueber self-assigned this Aug 19, 2022
@SGrueber SGrueber added the bug Something isn't working label Aug 19, 2022
@SGrueber SGrueber added this to the 3.1 milestone Aug 19, 2022
@SGrueber SGrueber requested a review from shauke August 22, 2022 10:12
@SGrueber SGrueber force-pushed the fix/filter_for_variation_master branch from f3ae025 to 79a8cda Compare August 25, 2022 14:06
@SGrueber SGrueber requested a review from dhhyi August 25, 2022 14:08
@SGrueber SGrueber force-pushed the fix/filter_for_variation_master branch from 79a8cda to 4515f87 Compare August 26, 2022 09:26
@shauke
Copy link
Collaborator

shauke commented Aug 26, 2022

See comment #1254 (comment) too.

… products of the product listing component (#1252)

BREAKING CHANGE: Changed default queryParamsHandling for product detail links via product image or product name component (see [Migrations / 3.0 to 3.1](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#30-to-31) for more details).
@shauke shauke force-pushed the fix/filter_for_variation_master branch from 4515f87 to 8d86405 Compare August 26, 2022 16:49
@shauke shauke merged commit 8a4f66e into develop Aug 26, 2022
@shauke shauke deleted the fix/filter_for_variation_master branch August 26, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants