Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fallbackLocales to show translations even if there is no connection to the server #1259

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Aug 26, 2022

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Precondition: the pwa cannot connect to the ICM server, e.g. because of a wrong base URL

  • without SSR (multichannel configuration) - if the user requests a page in German (route parameter lang=de_DE) the error page will be shown in English
  • with multichannel config: The translations of the json files are not returned all texts are missing in the page (missing translation is shown)

Issue Number: Closes #

What Is the New Behavior?

The error page is shown in the requested locale if the server doesn't respond

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#79145
AB#78921

@SGrueber SGrueber self-assigned this Aug 26, 2022
@SGrueber SGrueber added this to the 3.1 milestone Aug 26, 2022
@Eisie96 Eisie96 self-requested a review August 31, 2022 15:31
@shauke shauke marked this pull request as ready for review September 1, 2022 09:33
@shauke shauke changed the title fix: add defaultLocales to show translations even if there is no connection to the server fix: add fallbackLocales to show translations even if there is no connection to the server Sep 1, 2022
@shauke shauke merged commit 9b3ec42 into develop Sep 2, 2022
@shauke shauke deleted the bugfix/missing_translations_if_offline branch September 2, 2022 06:38
@SGrueber SGrueber mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants