Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use product price api for retail sets and product master #1262

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented Aug 29, 2022

PR Type

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Retail sets and product masters use the old product REST API to display prices ranges. This should be replaced with the new product price REST api.

Issue Number: Closes #

What Is the New Behavior?

The new product price REST API is used.

Does this PR Introduce a Breaking Change?

[ ] Yes
[ x ] No

Other Information

AB#79168

@Eisie96 Eisie96 force-pushed the bugfix/price-api-for-retail-sets-master-product branch 3 times, most recently from 8dafe5e to 7a00020 Compare August 29, 2022 15:04
@Eisie96 Eisie96 requested a review from shauke August 30, 2022 07:32
@shauke shauke added this to the 3.1 milestone Aug 31, 2022
* cleanup of obsolete product prices related code
@shauke shauke force-pushed the bugfix/price-api-for-retail-sets-master-product branch from 7a00020 to 33b3114 Compare August 31, 2022 16:22
shauke
shauke previously approved these changes Aug 31, 2022
@shauke shauke merged commit 208decc into develop Sep 5, 2022
@shauke shauke deleted the bugfix/price-api-for-retail-sets-master-product branch September 5, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants