Quoting feature results in a non stable application on certain pages #1265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
If the 'quoting' feature is enabled, then all pages, where quoting components are rendered (/account, /account/quotes), are not stable. This problem is caused by the automatic refresh of quoting entities with the use of the 'timer' operator in the quotingEntities$ observable pipe.
Issue Number: Closes #1264
What Is the New Behavior?
The quotingEntities$ function has a new automaticRefresh option. When the option is enabled, the timer operator will be executed right after the app is stable.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x ] No
Other Information
If the automaticRefresh option is enabled, it is necessary to subscribe to the quotingEntities$ observable in the component and to manually trigger the change detection. The reason for that is, that the used ApplicationRef.isStable observable runs outside of the Angular zone. It will not trigger the change detection automatically and not update the template.(https://docs.angular.lat/api/core/ApplicationRef)
Example from documentation:
AB#79432