Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reuse default product listing type for mobile #1268

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Sep 9, 2022

PR Type

[x] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

#1243 introduced a new environment config variable to handle default listing view types for mobile, while the existing variable could have been extended,

What Is the New Behavior?

  • Existing variable is extended.
  • Existing variable is made optional.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#79484

@dhhyi dhhyi self-assigned this Sep 9, 2022
@dhhyi dhhyi added refactoring Refactoring of current code community Community contributions labels Sep 9, 2022
@dhhyi dhhyi removed their assignment Sep 9, 2022
@dhhyi dhhyi marked this pull request as ready for review September 9, 2022 23:38
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A documented example for how to set the view type for the two different device types would be nice in the environment.model.ts for those of us that cannot read the matrix. ;)

@shauke shauke added this to the 3.1 milestone Sep 13, 2022
@dhhyi dhhyi force-pushed the refactor/reuse-default-product-listing-type branch from fb9a072 to b157947 Compare September 13, 2022 11:45
@dhhyi dhhyi requested a review from shauke September 13, 2022 11:45
@dhhyi dhhyi assigned shauke and unassigned dhhyi Sep 13, 2022
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very nice with this documentation. 😄

@shauke shauke merged commit 713675e into develop Sep 13, 2022
@shauke shauke deleted the refactor/reuse-default-product-listing-type branch September 13, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions refactoring Refactoring of current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants