Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair dead-code script exclude comments search #1273

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Sep 14, 2022

PR Type

[x] Bugfix

What Is the Current Behavior?

Issue Number: Closes #1222

What Is the New Behavior?

  • special case for finding exclude comment on VariableStatements
  • cleanup unused dead-code excludes

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#79590

@dhhyi dhhyi added bug Something isn't working community Community contributions labels Sep 14, 2022
@dhhyi dhhyi self-assigned this Sep 14, 2022
@dhhyi dhhyi changed the title fix: repair dead-code script exclude comments finding fix: repair dead-code script exclude comments search Sep 14, 2022
@dhhyi dhhyi removed their assignment Sep 14, 2022
@dhhyi dhhyi marked this pull request as ready for review September 14, 2022 12:56
SGrueber
SGrueber previously approved these changes Sep 19, 2022
@SGrueber SGrueber added this to the 3.1 milestone Sep 19, 2022
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the script fix. 👍

@shauke shauke merged commit 634f087 into develop Sep 21, 2022
@shauke shauke deleted the fix/repair-dead-code-script branch September 21, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community Community contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find-dead-code script exception do not work for variable declarations
3 participants