fix: rework category completeness computation #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verwrites less complete one * categoryRef was missing for categories that should already have this information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so more complete data overwrites less complete one
PR Type
[x] Bugfix
What Is the Current Behavior?
For some category levels (second level) after the initial load of the category main navigation tree the
categoryRefinformation is missing.The information is part of the REST response but it is somehow not mapped/copied right to the state management.
After a category details call it is available in the state.
What Is the New Behavior?
Category Completeness Level is calculated considering more relevant response information to have better distinct completeness levels for merging the correct category information.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#79621