Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display filter navigation after page refresh (F5) #1286

Merged
merged 2 commits into from
Oct 7, 2022
Merged

fix: display filter navigation after page refresh (F5) #1286

merged 2 commits into from
Oct 7, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 5, 2022 •
edited
Loading

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

  1. If a logged in user navigates to a category family page with filter navigation and presses F5 (page refresh) the category page is displayed without filter navigation.
  2. If an anonymous user selects a filter on a family page and clicks the login link the filter gets lost.

Issue Number: Closes #1232, #468

What Is the New Behavior?

  1. The filter navigation is displayed after refreshing the page.
  2. The filter remains unchanged if a user clicks login.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#80062

@SGrueber SGrueber self-assigned this Oct 5, 2022
@SGrueber SGrueber added the bug Something isn't working label Oct 5, 2022
@SGrueber SGrueber added this to the 3.1 milestone Oct 5, 2022
SGrueber added a commit that referenced this pull request Oct 5, 2022
@SGrueber
fix: prevent filter changes when opening sign in popup (#468, #1286)
90e858b
@SGrueber SGrueber linked an issue Oct 5, 2022 that may be closed by this pull request
PLP filters break when opening Sign In popup #468
Closed
SGrueber added a commit that referenced this pull request Oct 5, 2022
@SGrueber
fix: prevent filter changes when opening sign in popup (#468, #1286)
1d8aea9
@SGrueber SGrueber force-pushed the bugfix/display_filter_navigation_after_refresh branch from 90e858b to 1d8aea9 Compare October 5, 2022 15:15
@shauke shauke force-pushed the bugfix/display_filter_navigation_after_refresh branch from 1d8aea9 to 63b1509 Compare October 7, 2022 11:50
@shauke shauke merged commit ef234c1 into develop Oct 7, 2022
@shauke shauke deleted the bugfix/display_filter_navigation_after_refresh branch October 7, 2022 11:51
shauke pushed a commit that referenced this pull request Oct 7, 2022
@SGrueber @shauke
fix: display filter navigation after page refresh with logged in user (…
c6bbe51 
…#1232, #1286)

closes: #1232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

Assignees

@SGrueber SGrueber

Labels
bug Something isn't working
Projects
None yet
Milestone
3.1
2 participants
@SGrueber @shauke