Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: entry and display of the email address during the checkout process of an anonymous user #1312

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 26, 2022

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If an anonymous user starts the checkout he can enter an email address.

1. The email address is not shown on any checkout page
2. If the user navigates back to the checkout address page and enters another invoice address address the email address gets lost and the user is able to place the order without email address.
3. The email address cannot be changed by the user during checkout.
4. The email address is not validated in the checkout as guest form.
5. Company address fields are not shown in the checkout address form for anonymous users.

Issue Number: Closes #1303

What Is the New Behavior?

1. The email address of an anonymous user should always be displayed as part of the invoice address, i.e. in the invoice address widget of the checkout address page, the checkout right panel and the invoice address on review/receipt/order detail page
2. The anonymous user should not be able to enter a new invoice address, he can only change his invoice address. He can enter a new shipping address if his invoice and shipping addresses are equal.
3. For anonymous users the email address should be added to the invoice address form on the checkout address page.
4. The email address is validated in the checkout as guest form.
5. Company address fields are shown in the checkout address form for anonymous users.

Besides this the company input fields are shown on the edit address form for an anonymous b2b user on checkout address page.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#80664

@SGrueber SGrueber self-assigned this Oct 26, 2022
@SGrueber SGrueber added the bug Something isn't working label Oct 26, 2022
@SGrueber SGrueber added this to the 3.2 milestone Oct 26, 2022
@SGrueber SGrueber force-pushed the bugfix/checkout_email_for_anonymous_users branch 3 times, most recently from 00b49c2 to 2f19f0b Compare October 27, 2022 18:32
@SGrueber SGrueber marked this pull request as ready for review October 27, 2022 18:32
@SGrueber SGrueber requested a review from shauke October 27, 2022 18:32
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Azure Demo Servers are available:

Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ability to change the "Company Name" and "Company Name 2" is missing if guest checkout is used with B2B. 😉
Everything else looks good. 👍

@SGrueber SGrueber requested a review from shauke November 11, 2022 11:30
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A different shipping address cannot be removed/switched to the invoice address.
"Add Address" behaves like the "Edit Address"

image

@SGrueber SGrueber force-pushed the bugfix/checkout_email_for_anonymous_users branch from 228c749 to ab66117 Compare November 18, 2022 08:34
@SGrueber SGrueber requested a review from shauke November 18, 2022 13:03
@SGrueber
Copy link
Collaborator Author

The add address link is not displayed any more if an anonymous user has a differing shipping address. The select box is only shown for logged in customers because it shows customer addresses, an anonymous user has only basket addresses, so if he changes his mind and wants to deliver to his invoice address he has to reenter this address.

shauke
shauke previously approved these changes Nov 18, 2022
@SGrueber SGrueber force-pushed the bugfix/checkout_email_for_anonymous_users branch from 9376a93 to 0da5d13 Compare November 21, 2022 09:53
@SGrueber SGrueber merged commit 23a9257 into develop Nov 21, 2022
@SGrueber SGrueber deleted the bugfix/checkout_email_for_anonymous_users branch November 21, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display and change of an anonymous user's email address in the checkout
2 participants