fix: 'npm install' not working with PWA release zip file #1314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
If the PWA 3.1.0 release assets (zip or tar.gz - https://github.com/intershop/intershop-pwa/releases/tag/3.1.0) files are used to start a PWA it fails at the
npm install
.This is due to the lazy components schematic needing git and a git repository but it checked only for the git command not for being in a git repository.
What Is the New Behavior?
Changed the check from
git --version
togit status
to check for both relevant requirements.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#80842