Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: route to product detail page if only one search result was found #1316

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

tdonthu
Copy link
Contributor

@tdonthu tdonthu commented Nov 4, 2022

PR Type

[x] Feature

What Is the Current Behavior?

When searching for products and only one product is returned as the search result (either through searching explicitly for an SKU or by name) this product is displayed in the product list and a user would need to click it to switch to the product detail page.

What Is the New Behavior?

When searching for products and only one product is returned as the search result a redirect to the product detail page is automatically done.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#80856

@shauke shauke self-assigned this Nov 21, 2022
@github-actions
Copy link

Azure Demo Servers are available:

@shauke shauke added this to the 3.2 milestone Nov 29, 2022
shauke added a commit that referenced this pull request Nov 29, 2022
#1316)

- handled in `searchProducts$` effect
- fixed a searchbox issue for submitting a search term without suggestions with enter
- adapted and added tests for new interaction
@shauke shauke force-pushed the feature_on-search-single-result-to-pdp-page branch from 2d094e8 to 4bc7541 Compare November 29, 2022 16:57
@shauke shauke changed the title feat:on search single result redirect to PDP feat: route to product detail page if only one search result was found Nov 29, 2022
@shauke shauke requested a review from SGrueber November 29, 2022 18:19
@shauke shauke added the feature New feature or request label Nov 30, 2022
SGrueber
SGrueber previously approved these changes Nov 30, 2022
#1316)

- handled in `searchProducts$` effect
- adapted and added tests for new interaction
@shauke shauke force-pushed the feature_on-search-single-result-to-pdp-page branch from 4bc7541 to 7d810f8 Compare November 30, 2022 09:51
@shauke shauke merged commit 9964ebd into develop Nov 30, 2022
@shauke shauke deleted the feature_on-search-single-result-to-pdp-page branch November 30, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants