feat: enhanced variation selection with color code and swatch image #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
force-pushed
the
feat-variation-select-with-color-tile
branch
from
622a474 to
1c3988d
Compare
|
Azure Demo Servers are available: |
shauke
changed the title
iwiederhold
requested changes
Dec 14, 2022
|
Azure Demo Servers are available: |
… call (#1317) * changed products service to use `extended=true` REST calls for product details and variations * added VariationAttributeMapper to map variation attributes with attributeType and metaData * backwards compatible preparation for distinct variation select displays BREAKING CHANGES: `ProductsService` was changed to use an `extended=true` details and variations call. `VariationAttribute` model was cleaned up and extended (see [Migrations / 3.1 to 3.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#31-to-32) for more details).
shauke
added a commit
that referenced
this pull request
Dec 16, 2022
…splay (#1317) * moved existing `ProductVariationSelectComponent` rendering as standard select box to new `ProductVariationSelectDefaultComponent` * `ProductVariationSelectComponent` now contains the logic to select the fitting variation select rendering component * added `ProductVariationSelectSwatchComponent` for colorCode and swatchImage variation select rendering * added `ProductVariationSelectEnhancedComponent` for a select box rendering with color codes or swatch images and a mobile optimization BREAKING CHANGES: Changed the rendering of the `ProductVariationSelectComponent` and introduced additional product variation select rendering components (see [Migrations / 3.1 to 3.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#31-to-32) for more details). Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
feat-variation-select-with-color-tile
branch
from
26af412 to
9b6b91e
Compare
shauke
previously approved these changes
Dec 16, 2022
|
Please consider the arrow icon in both drop-downs the same. Also, to maintain consistency, please apply font weight for 256 GB as well.
THX! |
…splay (#1317) * moved existing `ProductVariationSelectComponent` rendering as standard select box to new `ProductVariationSelectDefaultComponent` * `ProductVariationSelectComponent` now contains the logic to select the fitting variation select rendering component * added `ProductVariationSelectSwatchComponent` for colorCode and swatchImage variation select rendering * added `ProductVariationSelectEnhancedComponent` for a select box rendering with color codes or swatch images and a mobile optimization BREAKING CHANGES: Changed the rendering of the `ProductVariationSelectComponent` and introduced additional product variation select rendering components (see [Migrations / 3.1 to 3.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#31-to-32) for more details). Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
feat-variation-select-with-color-tile
branch
from
9b6b91e to
cfc4f8a
Compare
shauke
added a commit
that referenced
this pull request
Dec 16, 2022
… call (#1317) * changed products service to use `extended=true` REST calls for product details and variations * added VariationAttributeMapper to map variation attributes with attributeType and metaData * backwards compatible preparation for distinct variation select displays BREAKING CHANGES: `ProductsService` was changed to use an `extended=true` details and variations call. `VariationAttribute` model was cleaned up and extended (see [Migrations / 3.1 to 3.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#31-to-32) for more details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
Currently the PWA renders for the variation selection only standard select boxes with standard options even though different variation selection types can be configured in the ICM back end.
What Is the New Behavior?
This pull request introduces an extended
/variationsand/productsREST call and a variation attribute mapper to fetch and prepare/map additional variation information required for distinct renderings.It also introduces different rendering components for
Default,Swatch Image/HTML Color CodeandDefault and Swatch Image/Default and HTML Color Code(including a mobile view adaption).Does this PR Introduce a Breaking Change?
[x] Yes
/variationsand/productsREST callOther Information
AB#80929