-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: message to merchant component #1323
Conversation
Azure Demo Servers are available: |
Azure Demo Servers are available: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls, add an e2e test
...quisition-management/src/app/pages/requisition-detail/requisition-detail-page.component.html
Outdated
Show resolved
Hide resolved
src/app/pages/checkout-receipt/checkout-receipt/checkout-receipt.component.html
Outdated
Show resolved
Hide resolved
src/app/pages/checkout-review/checkout-review/checkout-review.component.html
Outdated
Show resolved
Hide resolved
...omponents/basket/basket-merchant-message-view/basket-merchant-message-view.component.spec.ts
Show resolved
Hide resolved
...red/components/basket/basket-merchant-message-view/basket-merchant-message-view.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/basket/basket-merchant-message/basket-merchant-message.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/basket/basket-merchant-message/basket-merchant-message.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no complaints regarding the .md file from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
src/app/pages/checkout-review/checkout-review/checkout-review.component.html
Outdated
Show resolved
Hide resolved
Azure Demo Servers are available: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ui changes are done but the pencil is still missing, pls add it only if the component is displayed on review page
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
PR Type
[ ] Bugfix
[X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
There is no message to merchant area during checkout.
What Is the New Behavior?
Message to merchant component added on shipping page to the checkout process. Shoppers will be able to send messages to merchants.
Does this PR Introduce a Breaking Change?
[ ] Yes
[X ] No
Other Information
Limitations
The user is not able to delete a message once he has already saved one. This is due to an issue in the REST API. The fix for it will be available with ICM 7.10.38.2 or higher.
We will enable the user to delete his message to merchant in the pwa after the ICM fix has been released..
AB#81043