Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: message to merchant component #1323

Merged
merged 18 commits into from
Feb 9, 2023
Merged

Conversation

DilaraGueler
Copy link
Contributor

@DilaraGueler DilaraGueler commented Nov 10, 2022

PR Type

[ ] Bugfix
[X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

There is no message to merchant area during checkout.

What Is the New Behavior?

Message to merchant component added on shipping page to the checkout process. Shoppers will be able to send messages to merchants.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X ] No

Other Information

Limitations

The user is not able to delete a message once he has already saved one. This is due to an issue in the REST API. The fix for it will be available with ICM 7.10.38.2 or higher.
We will enable the user to delete his message to merchant in the pwa after the ICM fix has been released..

AB#81043

@SGrueber SGrueber reopened this Nov 11, 2022
@github-actions
Copy link

Azure Demo Servers are available:

@DilaraGueler DilaraGueler changed the title feature: message to merchant component first design feat: message to merchant component first design Nov 15, 2022
@DilaraGueler DilaraGueler changed the title feat: message to merchant component first design feat: message to merchant component Nov 15, 2022
@DilaraGueler DilaraGueler added the feature New feature or request label Nov 16, 2022
@DilaraGueler DilaraGueler self-assigned this Nov 16, 2022
@github-actions
Copy link

Azure Demo Servers are available:

@shauke shauke added the wait Waiting for something (e.g. new ICM release) label Dec 22, 2022
@SGrueber SGrueber marked this pull request as ready for review January 12, 2023 10:58
Copy link
Collaborator

@SGrueber SGrueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls, add an e2e test

@SGrueber SGrueber removed the wait Waiting for something (e.g. new ICM release) label Jan 13, 2023
@SGrueber SGrueber added this to the 3.3 milestone Jan 13, 2023
marschmidt89
marschmidt89 previously approved these changes Jan 30, 2023
Copy link
Contributor

@marschmidt89 marschmidt89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no complaints regarding the .md file from my side

Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merchant_message_edit_missing


merchant_message_label_spaces

Copy link

@schadii schadii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move text area and apply button to the right to be aligned with others above input fields. Or as another suggestion, omit “Message to merchant” label. Although in this case it can affect accessibility.
Message to merchant

schadii
schadii previously approved these changes Feb 2, 2023
Copy link

@schadii schadii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Azure Demo Servers are available:

@SGrueber SGrueber requested a review from iwiederhold February 2, 2023 09:44
Copy link
Collaborator

@SGrueber SGrueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui changes are done but the pencil is still missing, pls add it only if the component is displayed on review page

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Azure Demo Servers are available:

@schadii schadii self-requested a review February 8, 2023 13:12
schadii
schadii previously approved these changes Feb 8, 2023
@iwiederhold
Copy link

After editing the merchant message again, you get an error.

image

@DilaraGueler
Copy link
Contributor Author

@DilaraGueler DilaraGueler reopened this Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Azure Demo Servers are available:

@SGrueber SGrueber merged commit 50cbe36 into develop Feb 9, 2023
@SGrueber SGrueber deleted the feature/basket-merchant-message branch February 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants