Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save desired delivery date at basket items #1325

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Nov 17, 2022

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The desired delivery date is only saved at the basket as custom attribute 'desiredDeliveryDate'. In a standard ICM back office it is not shown.

Issue Number: Closes #

What Is the New Behavior?

After the user has entered a desired delivery date on checkout shipping page it is additionally saved at all basket items. This way it is shown in the ICM back office in the order items table and can also be transferred to other back end systems like the IOM.

Limitation: In case of large baskets (> 20 items) saving the desired delivery date at all basket items might cause (unacceptable) long response times, a possible solution for this would be to implement this feature in the ICM back end. Maybe in future there will also be a bulk REST call to overcome this.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

This feature requires an ICM 7.10.39 or higher

AB#81176

@SGrueber SGrueber self-assigned this Nov 17, 2022
@SGrueber SGrueber added feature New feature or request enhancement Enhancement to an existing feature and removed feature New feature or request labels Nov 17, 2022
@SGrueber SGrueber added this to the 3.2 milestone Nov 17, 2022
@SGrueber SGrueber force-pushed the feature/desired_delivery_date_at_basket_items branch from 009f15d to eccfc1f Compare November 17, 2022 14:52
@github-actions
Copy link

Azure Demo Servers are available:

@SGrueber SGrueber force-pushed the feature/desired_delivery_date_at_basket_items branch from eccfc1f to ab49936 Compare November 22, 2022 13:57
@SGrueber SGrueber force-pushed the feature/desired_delivery_date_at_basket_items branch from ab49936 to a40e096 Compare November 22, 2022 14:50
@SGrueber SGrueber merged commit f8fba29 into develop Nov 24, 2022
@SGrueber SGrueber deleted the feature/desired_delivery_date_at_basket_items branch November 24, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants