feat: product notifications #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
requested changes
Nov 18, 2022
...ations/pages/account-product-notifications/account-product-notifications-page.component.html
Outdated
Show resolved
Hide resolved
...nsions/product-notifications/models/product-notification/product-notification.mapper.spec.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/product-notifications/pages/product-notifications-routing.module.ts
Outdated
Show resolved
Hide resolved
...nsions/product-notifications/services/product-notifications/product-notifications.service.ts
Show resolved
Hide resolved
.../extensions/product-notifications/store/product-notification/product-notification.actions.ts
Outdated
Show resolved
Hide resolved
.../extensions/product-notifications/store/product-notification/product-notification.actions.ts
Outdated
Show resolved
Hide resolved
.../extensions/product-notifications/store/product-notification/product-notification.effects.ts
Outdated
Show resolved
Hide resolved
src/app/extensions/product-notifications/store/product-notifications-store.module.ts
Show resolved
Hide resolved
src/app/extensions/product-notifications/store/product-notifications-store.module.ts
Outdated
Show resolved
Hide resolved
suschneider
force-pushed
the
feature/product-notifications
branch
from
3685ff8 to
a3f7503
Compare
suschneider
force-pushed
the
feature/product-notifications
branch
from
673bdc9 to
e37caeb
Compare
suschneider
force-pushed
the
feature/product-notifications
branch
from
80dfb5e to
58b6d7a
Compare
suschneider
force-pushed
the
feature/product-notifications
branch
from
c1b0dbb to
2346734
Compare
suschneider
force-pushed
the
feature/product-notifications
branch
from
2346734 to
d907974
Compare
andreassteinmann
force-pushed
the
feature/product-notifications
branch
from
93f4c52 to
5d2dab1
Compare
|
Azure Demo Servers are available: |
3 similar comments
|
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
mglatter
reviewed
Mar 9, 2023
mglatter
reviewed
Mar 9, 2023
mglatter
previously approved these changes
Mar 9, 2023
|
add a note in the migrations.md about the introduction of the new feature toggle, the new feature toggle should also be added to the feature toggle overview in the configurations.md |
SGrueber
requested changes
Mar 13, 2023
e2e/cypress/e2e/pages/account/edit-product-notification.module.ts
Outdated
Show resolved
Hide resolved
...ications/pages/account-product-notifications/account-product-notifications-page.component.ts
Show resolved
Hide resolved
src/app/extensions/product-notifications/product-notifications.module.ts
Outdated
Show resolved
Hide resolved
...cations/account-product-notifications-list/account-product-notifications-list.component.html
Outdated
Show resolved
Hide resolved
.../extensions/product-notifications/store/product-notification/product-notification.effects.ts
Outdated
Show resolved
Hide resolved
.../extensions/product-notifications/store/product-notification/product-notification.reducer.ts
Show resolved
Hide resolved
...xtensions/product-notifications/store/product-notification/product-notification.selectors.ts
Outdated
Show resolved
Hide resolved
...ions/product-notifications/store/product-notification/product-notification.selectors.spec.ts
Outdated
Show resolved
Hide resolved
src/app/pages/product/product-detail/product-detail.component.html
Outdated
Show resolved
Hide resolved
…d getProductNotificationsByType
…ired, there are no required markers)
shauke
force-pushed
the
feature/product-notifications
branch
from
3f063dc to
abdaada
Compare
shauke
previously approved these changes
Mar 31, 2023
…ion key optimization
shauke
force-pushed
the
feature/product-notifications
branch
from
abdaada to
e9eef5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X ] Feature
What Is the Current Behavior?
There is no product notification functionality available in the PWA.
What Is the New Behavior?
The product notification functionality for in stock and price notifications in the My Account Area (listing/editing/deleting) and on PDP (creating/editing/deleting) is implemented as an extension for the PWA.
Limitation
The language specific entry of money amounts is not possible, only the English format is supported.
Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
Requires ICM version 7.10.40.1 for adapted email templates, REST functionality is already available
AB#81192