fix: prevent budget bar arrow and product label ribbons to be shown in the subcategories layer #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nside the subcategories layer
shauke
approved these changes
Nov 22, 2022
shauke
deleted the
fix/absolute-positioned-elements-shown-in-subcategories-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Two absolute positioned elements are shown in the subcategories layer when a user hovers over a catalog in the header:
Budget bar indicator:
Budget bar indicator when hovering the catalog:
Product list product label ribbon:
Product list product label ribbon when hovering the catalog:
Product detail page product label ribbon:
Product detail page product label ribbon when hovering the catalog:
Issue Number: Closes #
Related issue: #762
What Is the New Behavior?
The budget bar indicator and the product label ribbon should not be shown in the subcategories layer.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x ] No
Other Information
AB#81281