feat: keyboard accessibility rule added #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
feature/accessibility
branch
from
f37eb08
to
2427295
Compare
SGrueber
previously requested changes
Dec 9, 2022
...s/quoting/shared/quote-line-item-list-element/quote-line-item-list-element.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/filter/filter-swatch-images/filter-swatch-images.component.spec.ts
Outdated
Show resolved
Hide resolved
DilaraGueler
force-pushed
the
feature/accessibility
branch
from
bcb91e6
to
f39c01d
Compare
shauke
force-pushed
the
feature/accessibility
branch
from
f39c01d
to
c521e68
Compare
marschmidt89
previously approved these changes
Jan 6, 2023
shauke
pushed a commit
that referenced
this pull request
Jan 11, 2023
…' rule for '<a>' tags (#1336) * apply consistent `[routerLink]="[]"` pattern for links without a `routerLink`
shauke
pushed a commit
that referenced
this pull request
Jan 11, 2023
…HTML elements with click event (#1336) * add `(keydown.enter)` events for `(click)` events * make elements tab focusable with `tabindex="0"`
shauke
force-pushed
the
feature/accessibility
branch
from
b7aa8ad
to
a197370
Compare
shauke
previously approved these changes
Jan 11, 2023
shauke
force-pushed
the
feature/accessibility
branch
from
a197370
to
a6bb678
Compare
shauke
approved these changes
Jan 11, 2023
shauke
approved these changes
Jan 11, 2023
shauke
pushed a commit
that referenced
this pull request
Jan 11, 2023
…' rule for '<a>' tags (#1336) * apply consistent `[routerLink]="[]"` pattern for links without a `routerLink`
shauke
pushed a commit
that referenced
this pull request
Jan 11, 2023
…HTML elements with click event (#1336) * add `(keydown.enter)` events for `(click)` events * make elements tab focusable with `tabindex="0"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X ] Feature
What Is the Current Behavior?
Accessibility with keyboard is missing for some components.
What Is the New Behavior?
Accessibility rule is added to the ESLint rules and required components adjusted to the new rule. It is possible to use the website with a keyboard better than before instead of a mouse.
Does this PR Introduce a Breaking Change?
[X] No
Other Information
AB#81745