feat: extension address doctor #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
requested review from
NicolasGrizard and
marschmidt89
and removed request for
NicolasGrizard
jah-1206
reviewed
Jan 17, 2023
| @@ -0,0 +1,6 @@ | |||
| export interface AddressDoctorConfig { | |||
| login: string; | |||
| password: string; | |||
There was a problem hiding this comment.
Hi,
I can't really find the recommendations from Address Doctor to use their apis, is it secure to store in the front the login and password to use their services ? Isn't there a risk for someone to collect it ?
There was a problem hiding this comment.
@charleshopfner The client needs to send the login and password with the POST REST request in plain text to the Address Doctor server. So the client will have to know these values at some point.
In a production environment these values are set via an environment variable at deployment time, so the values are not part of the actual source code and we assume that is "secret" enough.
But we are open to any suggestions how this could be handled better if necessary.
Eisie96
force-pushed
the
feature/extension_address_doctor
branch
from
4417c69 to
b5535c1
Compare
Eisie96
force-pushed
the
feature/extension_address_doctor
branch
from
b5535c1 to
3c4296a
Compare
shauke
force-pushed
the
feature/extension_address_doctor
branch
from
9f220d3 to
ec03c2a
Compare
…ervice * can be used to conditionally, based on a feature toggle, reference additional functionality in extensions from the main application * introduced to be used by the Address Doctor extension
shauke
added a commit
that referenced
this pull request
Jun 21, 2023
* introduce notifier service to notify address doctor for new address check * use feature event service to notify extensions for further actions from the outside * use formly for address doctor form * mapper to map address doctor data to Intershop compatible Address interface * implement caching functionality to avoid unnecessary REST requests * add additional documentation for address doctor * introduce helper to check addresses for equality * don't open modal when no suggestions are available * update existing address form with selected address before submitting Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
feature/extension_address_doctor
branch
from
36c9465 to
fbbc30f
Compare
shauke
added a commit
that referenced
this pull request
Jun 21, 2023
* introduce notifier service to notify address doctor for new address check * use feature event service to notify extensions for further actions from the outside * use formly for address doctor form * mapper to map address doctor data to Intershop compatible Address interface * implement caching functionality to avoid unnecessary REST requests * add additional documentation for address doctor * introduce helper to check addresses for equality * don't open modal when no suggestions are available * update existing address form with selected address before submitting Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
feature/extension_address_doctor
branch
from
fbbc30f to
4b5b54d
Compare
shauke
previously approved these changes
Jun 21, 2023
* introduce notifier service to notify address doctor for new address check * use feature event service to notify extensions for further actions from the outside * use formly for address doctor form * mapper to map address doctor data to Intershop compatible Address interface * implement caching functionality to avoid unnecessary REST requests * add additional documentation for address doctor * introduce helper to check addresses for equality * don't open modal when no suggestions are available * update existing address form with selected address before submitting Co-authored-by: Marcel Eisentraut <meisentraut@intershop.de> Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
feature/extension_address_doctor
branch
from
4b5b54d to
91a5a79
Compare
shauke
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
There is no Address Doctor Extension to check if the entered address is valid.
Issue Number: Closes #
What Is the New Behavior?
This feature is intended to integrate the Address Doctor address validation web service. If the feature is enabled, a call to the web service will be executed whenever a new address needs to be validated. After clicking the save button an Modal overlay will appear and you can choose the address you want. You can choose your entered or a suggestion from Address Doctor.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#81763