feat: product zoom feature #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Demo Servers are available: |
DilaraGueler
force-pushed
the
feature/product-zoom
branch
from
e71a451
to
2d59e31
Compare
suschneider
requested changes
Feb 13, 2023
There was a problem hiding this comment.
- The image that is displayed as the first large image when you open the PDP is missing in the thumbnail images.
- The size of ALL modal dialog is now screen width (see e.g. sign in modal dialog). Only the zoom image dialog should have this special styling. Since special functionality is also needed, it would be better to add a separate component for the zoom dialog.
- Use the styling 'cursor: zoom-in' in case zoom images are available to signal to the user that zooming is possible. And for the next and the previous button area of the image carousel the style 'cursor:pointer' would be nice.
suschneider
previously approved these changes
Feb 22, 2023
|
Azure Demo Servers are available: |
iwiederhold
requested changes
Feb 22, 2023
DilaraGueler
dismissed stale reviews from schadii and suschneider
via
c8fe4d3
|
Azure Demo Servers are available: |
iwiederhold
previously approved these changes
Feb 23, 2023
|
Azure Demo Servers are available: |
|
Please check the Zoom feature at a real mobile device. The previous button at the product detail page has a strange behavior after the zoom view. |
The back button's behavior will be discussed with another ticket not specifically on product zoom but all modal dialogs in the application. |
shauke
force-pushed
the
feature/product-zoom
branch
from
90315ac
to
7c851f2
Compare
|
Azure Demo Servers are available: |
2 similar comments
|
Azure Demo Servers are available: |
|
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/product-zoom
branch
2 times, most recently
from
d603d8c
to
58d13cc
Compare
|
Azure Demo Servers are available: |
…1350) * add support for fullscreen modal styling (similar to Bootstrap 5), use `modalDialogClass: 'modal-fullscreen'` instead of `size` * add `scrollToAnchor` method for automatic scrolling within a dialog * extend support for all `NgbModalOptions` (not only `size`)
shauke
force-pushed
the
feature/product-zoom
branch
from
58d13cc
to
a6aaa47
Compare
shauke
approved these changes
Apr 5, 2023
shauke
pushed a commit
that referenced
this pull request
Apr 5, 2023
…1350) * add support for fullscreen modal styling (similar to Bootstrap 5), use `modalDialogClass: 'modal-fullscreen'` instead of `size` * add `scrollToAnchor` method for automatic scrolling within a dialog * extend support for all `NgbModalOptions` (not only `size`)
shauke
pushed a commit
that referenced
this pull request
Apr 6, 2023
…1350) * add support for fullscreen modal styling (similar to Bootstrap 5), use `modalDialogClass: 'modal-fullscreen'` instead of `size` * add `scrollToAnchor` method for automatic scrolling within a dialog * extend support for all `NgbModalOptions` (not only `size`)
shauke
pushed a commit
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Product Zoom feature has been added to the Product Detail Page.
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
AB#82318