Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbar added to the approval tabs #1353

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

DilaraGueler
Copy link
Contributor

@DilaraGueler DilaraGueler commented Jan 10, 2023

PR Type

[ X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

On the phone view, the tabs have long names in the approval section. The complete page gets a horizontal scrollbar.

Issue Number: Closes #988

What Is the New Behavior?

The horizontal scrollbar is only usable for the tabs. The rest of the content is fixed.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X ] No

Other Information

AB#82472

@DilaraGueler DilaraGueler marked this pull request as ready for review January 11, 2023 17:23
@shauke shauke requested a review from SGrueber January 12, 2023 16:26
@SGrueber SGrueber self-requested a review January 13, 2023 08:37
Copy link
Collaborator

@SGrueber SGrueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui improvements needed for firefox (hide scrollbar, suppress unwanted lines)

src/styles/global/global.scss Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Azure Demo Servers are available:

@SGrueber SGrueber requested review from iwiederhold and removed request for Eisie96 February 2, 2023 14:17
Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the scrolling behavior on your phone too. On my phone the tabs move up and down when scrolling.

@shauke shauke added this to the 3.3 milestone Feb 8, 2023
@SGrueber
Copy link
Collaborator

SGrueber commented Feb 9, 2023

Please test the scrolling behavior on your phone too. On my phone the tabs move up and down when scrolling.

We won't fix this, it is a minor issue only occurring on iphones.

@SGrueber SGrueber merged commit 2ac7f03 into develop Feb 9, 2023
@SGrueber SGrueber deleted the bugfix/approval_tabs_need_scrollbar branch February 9, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Approval tabs need scrollbar in phone view
4 participants