Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shopping cart message needs more space #1356

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

DilaraGueler
Copy link
Contributor

@DilaraGueler DilaraGueler commented Jan 12, 2023

PR Type

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

  1. In the shopping cart item related info messages have no space on top.
  2. if a product is added to the cart again there is an info message.

Issue Number: Closes #

What Is the New Behavior?

  1. In the shopping cart item related info messages have a space on top.
  2. There is no info message any more if a product is added again to the shopping cart unless the maximum purchasing policy is not met.

Does this PR Introduce a Breaking Change?

[ ] Yes
[X] No

Other Information

AB#82592

@shauke shauke added this to the 3.3 milestone Feb 8, 2023
@shauke shauke requested a review from SGrueber February 10, 2023 17:19
@shauke shauke marked this pull request as ready for review February 10, 2023 17:20
@SGrueber SGrueber force-pushed the bugfix/shopping_cart_message branch from fbb6641 to 92b35b1 Compare February 13, 2023 11:06
@SGrueber SGrueber force-pushed the bugfix/shopping_cart_message branch from 92b35b1 to ae0c0d0 Compare February 13, 2023 11:22
@SGrueber SGrueber merged commit c05df22 into develop Feb 13, 2023
@SGrueber SGrueber deleted the bugfix/shopping_cart_message branch February 13, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants