fix: add basket ship-to-address to product prices call #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
sgrumbachIntershop
previously approved these changes
Jan 27, 2023
Eisie96
suggested changes
Jan 27, 2023
SGrueber
force-pushed
the
bugfix/refine_product_prices_call
branch
from
32c0d86
to
1f73e3b
Compare
Eisie96
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The product price call respects the customer's default shipping address for the (gross) price display, but if the user changes his basket ship-to-address to a country that has different taxes the prices shown on the cart page might differ from the prices on the product pages.
Issue Number: Closes #
What Is the New Behavior?
The customer's basket ship-to-address is added as a query parameter to the product price REST call to make the result more precise and avoid differences between prices on product pages and cart prices.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#81275
AB#82962