Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set correct URL for sharing product page via email #138

Merged
merged 1 commit into from
Mar 2, 2020
Merged

fix: set correct URL for sharing product page via email #138

merged 1 commit into from
Mar 2, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 2, 2020 •
edited
Loading

PR Type

[x] Bugfix

What Is the Current Behavior?

Issue Number:
Closes #128

What Is the New Behavior?

  • removed currentUrl$ from AppFacade
  • use document.URL for sharing link

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

Decided to use document.URL so it works both for SSR and Client Application

@dhhyi
fix: set correct URL for sharing product page via email (#128, #138)
10f7094 
- removed currentUrl$ from AppFacade
- use document.URL for sharing link

Closes #128
@dhhyi dhhyi added the bug Something isn't working label Mar 2, 2020
@dhhyi dhhyi added this to the 0.18 milestone Mar 2, 2020
@dhhyi dhhyi requested a review from shauke March 2, 2020 13:08
@dhhyi dhhyi self-assigned this Mar 2, 2020
@shauke shauke merged commit a338c22 into develop Mar 2, 2020
@shauke shauke deleted the bugfix/set_correct_url_for_sharing_per_email branch March 2, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

Assignees

@dhhyi dhhyi

Labels
bug Something isn't working
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.

miss-matched current url host with actual page host
2 participants
@dhhyi @shauke