fix: return a unique id in the line item list's trackBy function #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
approved these changes
Mar 20, 2023
SGrueber
added a commit
that referenced
this pull request
Mar 21, 2023
(cherry picked from commit 78d99d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
For rendering the line item list a trackBy function is used for performance reasons that returns the sku, but the sku is not always a unique identifier for the list items.
E.g. cart items might have the same sku if the ICM backoffice setting 'Add product behavior' (application shopping cart & checkout preference) is set to 'Allow repeats'. The default preference 'Merge quantities' is also not always applicable, e.g. if the product contains a warranty.
The equivocal trackBy return value might cause rendering problems on the line item list.
Issue Number: Closes #
What Is the New Behavior?
The trackby function returns the id as a unique value for a list item.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#84665