fix: quick quantity change on item lists #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
force-pushed
the
bugfix/quantity_change
branch
from
ccde5bf
to
e83b458
Compare
SGrueber
commented
Mar 24, 2023
|
A trackBy function is not needed for the retail set part component, because the initial data will not change, when e.g the product quantity increases. |
…sary component destroyments on changes
… avoid unneccary component destroyment on changes
SGrueber
force-pushed
the
bugfix/quantity_change
branch
from
fc6ef52
to
ec2957c
Compare
Eisie96
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
Actual Behavior
When I change the quantity of an item in the shopping cart, right after I have already changed the quantity before, the price of the item is not updated
Issue Number: Closes #1380
Expected Behavior
If I have the possibility to change the item quantity, I expect a correct update of the item
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#84676