feat: add "Product List (REST)" CMS component #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are now 4 cms product list components that all render the same html. Imo, it would be useful to create a new component that renders the stuff (input parameters: pagelet, skus ) |
SGrueber
requested changes
Mar 27, 2023
src/app/shared/cms/components/cms-product-list-rest/cms-product-list-rest.component.ts
Show resolved
Hide resolved
src/app/shared/cms/components/cms-product-list-rest/cms-product-list-rest.component.spec.ts
Show resolved
Hide resolved
andreassteinmann
previously approved these changes
Mar 28, 2023
shauke
force-pushed
the
feature/cms_product_list_rest_endpoint
branch
from
8ead03b
to
7c5f449
Compare
I would rather keep the rendering templates of CMS components self-sufficient and not create an additional general component that all use. For most parts all 4 CMS components already use the general |
SGrueber
previously approved these changes
Mar 31, 2023
shauke
force-pushed
the
feature/cms_product_list_rest_endpoint
branch
from
7c5f449
to
0098b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the New Behavior?
Adds support for an additional CMS component "Product List (REST)" that can render product lists based on any generic REST request (not just from ICM) that provides a simple or complex Array of product SKUs.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
Requires additional CMS Content Model
component.common.productListRest.pagelet2available with ICM 7.10.40.1AB#84814