fix: accessibility issues #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
commented
Apr 5, 2023
src/app/shell/header/language-switch/language-switch.component.html
Outdated
Show resolved
Hide resolved
...app/extensions/store-locator/shared/store-locator-footer/store-locator-footer.component.html
Outdated
Show resolved
Hide resolved
src/app/shell/header/header-navigation/header-navigation.component.html
Outdated
Show resolved
Hide resolved
SGrueber
commented
Apr 6, 2023
src/app/shared/components/product/product-list-toolbar/product-list-toolbar.component.html
Outdated
Show resolved
Hide resolved
SGrueber
commented
Apr 18, 2023
projects/organization-management/src/app/components/user-budget/user-budget.component.html
Outdated
Show resolved
Hide resolved
SGrueber
commented
May 5, 2023
...anization-management/src/app/components/cost-center-budget/cost-center-budget.component.html
Outdated
Show resolved
Hide resolved
...zation-management/src/app/components/cost-center-budget/cost-center-budget.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/organization-management/src/app/components/user-budget/user-budget.component.ts
Outdated
Show resolved
Hide resolved
projects/organization-management/src/app/components/user-budget/user-budget.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/organization-management/src/app/pages/users/users-page.component.html
Outdated
Show resolved
Hide resolved
SGrueber
pushed a commit
that referenced
this pull request
May 11, 2023
* add/enhance roles, aria controls and aria labels
LucasHengelhaupt
approved these changes
May 11, 2023
added 3 commits
May 12, 2023 09:01
…'id' to 'elementId' (#1405)
* add/enhance roles, aria controls and aria labels
SGrueber
pushed a commit
that referenced
this pull request
May 15, 2023
…'id' to 'elementId' (#1405)
SGrueber
pushed a commit
that referenced
this pull request
May 15, 2023
* add/enhance roles, aria controls and aria labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Issue Number: Closes #
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#84994