Basket error modal window cant be closed #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
force-pushed
the
fix/unclosable-toaster-on-ssr
branch
from
099728a to
c7cd946
Compare
|
Good improvement, but we should check/discuss why there occurs an error in SSR in the first place. It is pretty normal that we cannot have a basket in SSR. and therefore there should not be an error. |
shauke
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
All toaster messages will currently be rendered on SSR, if a toaster action will be dispatched during the runtime on the server.
(empty basket on basket page)
It is not possible to dismiss the SSR rendered toaster on browser side.
Furthermore basket informations will be fetched on all basket pages even on SSR. It is not possible to retrieve a personalized basket on server side.
Issue Number: Closes #1403
What Is the New Behavior?
The message and the loadBasketOnBasketPage effects will only subscribe to the action stream if the app is running on browser side.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x ] No
Other Information
AB#85043