fix: display offline products #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suschneider
force-pushed
the
fix/display-offline-products
branch
2 times, most recently
from
0b66112
to
b598704
Compare
) * if a product REST call returns with an error (e.g. if the product is set to offline in ICM or if it does not exist at all) the product is marked as failed in the PWA state management * such failed products are now filtered and no longer rendered by the generic Products List component * the Product Tile and the Product Row component no longer render failed products as well * Products List component now maps the ProductContextDisplayProperties configuration as listItemConfiguration
…ecently viewed page (#1408) * by using the generic Products List component failed products are no longer rendered
* by using the generic Products List component failed products are no longer rendered
shauke
force-pushed
the
fix/display-offline-products
branch
from
24fa2c8
to
de8b11b
Compare
shauke
approved these changes
Apr 5, 2023
shauke
pushed a commit
that referenced
this pull request
Apr 5, 2023
) * if a product REST call returns with an error (e.g. if the product is set to offline in ICM or if it does not exist at all) the product is marked as failed in the PWA state management * such failed products are now filtered and no longer rendered by the generic Products List component * the Product Tile and the Product Row component no longer render failed products as well * Products List component now maps the ProductContextDisplayProperties configuration as listItemConfiguration
shauke
pushed a commit
that referenced
this pull request
Apr 5, 2023
…ecently viewed page (#1408) * by using the generic Products List component failed products are no longer rendered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
When setting a product to offline in the ICM, this product will still be displayed in the Intershop PWA under the "Recently Viewed" section. The display of the product is changed as soon as the page cache is invalidated via the ICM.
What Is the New Behavior?
The product that was set offline is no longer displayed in the "Recently Viewed" section.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
This is the same for featured products and the wish list widget in my account area.
AB#85105