fix: identity Provider init() should be triggered async #1415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICMIdentityProvider
can trigger a token refresh during the init phase.intershop-pwa/src/app/core/identity-provider/icm.identity-provider.ts
Lines 62 to 69 in a0e0ebd
In the case of optimized SSR rendering, all ngrx storage conditions will be met when the
IdentityProviderFactory
constructor is called.As a side effect, token refresh call an http request.
This http request is then intercepted by
identity-provider
intershop-pwa/src/app/core/interceptors/identity-provider.interceptor.ts
Lines 12 to 17 in a0e0ebd
In the worst case, if all of this chain of effect can be trigger before the constructor initialization and
identityProviderFactory
will beundefined
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Issue Number: Closes #
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information