chore: emit 'NotVisible' events when target element moves out of viewport #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
previously approved these changes
May 23, 2023
…Visible` status change as well BREAKING CHANGES: The `ishIntersectionObserver` returns `NotVisible` status now too (see [Migrations / 4.0 to 4.1](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#40-to-41) for more details).
shauke
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently the
ishIntersectionObservercan be used as directive on a target element to determine whether the element is visible. Whenever the element moves into view and becomes visible it will emit theIntersectionStatusVisible. Given the type definition forIntersectionStatus[export type IntersectionStatus = 'Visible' | 'Pending' | 'NotVisible';] I would expect that the directive also emits aNotVisibleevent when the target element becomes invisible. This is not the case, it only emitsPendingandVisiblestatuses.What Is the New Behavior?
The
ishIntersectionObserveralso emitsNotVisiblestatus.Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information