fix: force a name attribute on radio inputs #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radio inputs now have a correctly filled name attribute. When this attribute is not set and we bind a [formGroup] on the input, angular considers that the radio button is global. It is therefore impossible to create several different groups of radio buttons on the page (changing one of the buttons will erase the status of the others). This fix prevents this unexpected behavior
|
@tbouliere-datasolution : Thank you very much for this bugfix ! :-) |
SGrueber
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The name attribute of radio inputs is not set.
If we bind a
[formGroup]on theinput, angular considers that the radio button is global.It is therefore impossible to create several different groups of radio buttons on the page (changing one of the buttons will erase the status of the others).
Issue Number: Closes #
What Is the New Behavior?
Radio inputs now have a correctly filled name attribute.
This fix prevents this unexpected behavior.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information