perf: textarea description wrapper trigger to much changes #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring with the usage of a BehaviorSubject insted recreating the observable each time a change occured Also introduce the function throttleTime to limit refresh cycles on the front-end
Eisie96
previously requested changes
May 30, 2023
...hared/formly/wrappers/textarea-description-wrapper/textarea-description-wrapper.component.ts
Outdated
Show resolved
Hide resolved
...hared/formly/wrappers/textarea-description-wrapper/textarea-description-wrapper.component.ts
Outdated
Show resolved
Hide resolved
…Control changes to inner observable to translate description
SGrueber
approved these changes
Jun 7, 2023
SGrueber
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only one observable, which handles the translation of the changing description.
Also introduce the function
throttleTimeto limit refresh cycles on the front-endPR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Issue Number: Closes #
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x ] No
Other Information