feat: save language selection as cookie #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/preferred_locale_cookie
branch
from
87fd6b4
to
41a8790
Compare
|
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/preferred_locale_cookie
branch
from
41a8790
to
5ec1e6f
Compare
|
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/preferred_locale_cookie
branch
from
2a8400d
to
d4aa83a
Compare
SGrueber
force-pushed
the
feature/preferred_locale_cookie
branch
2 times, most recently
from
3777e44
to
b474698
Compare
|
It doesn't work, when the PWA is running locally with |
SGrueber
force-pushed
the
feature/preferred_locale_cookie
branch
4 times, most recently
from
3facd2f
to
ebb6420
Compare
|
Azure Demo Servers are available: |
|
Please check, when applying the preferred locale, that the locale is available. The problem can occur, when the Multi-Channel configuration contains different channel for different paths. - Done |
|
add a feature toggle to switch the behavior on/off - Done |
|
Azure Demo Servers are available: |
SGrueber
force-pushed
the
feature/preferred_locale_cookie
branch
from
792ffcc
to
cc4d110
Compare
SGrueber
force-pushed
the
feature/preferred_locale_cookie
branch
from
cc4d110
to
f357086
Compare
shauke
previously approved these changes
Sep 8, 2023
shauke
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
The pwa is always opened in the requested language according to the url/default language.
Issue Number: Closes #1489
What Is the New Behavior?
If the user changes the language the new language is saved as cookie 'preferredLocale' in the browser. The next time he/she opens the pwa the pwa is reloaded in this language if it differs from the current language and this language is supported by the PWA. This cookie is considered as a technically necessary cookie and will be set even if the user only accepts necessary cookies.
This feature is enabled by default and can be disabled by switching the feature toggle 'saveLanguageSelection' off.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#86776