fix: fix: handle token errors for local development #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of local development, you can change the target back-end by modifying the value of the variable icmBaseURL' variable in environment.developement.ts. By doing so, you will need a new api token. However, as your local DNS is still \"localhost\", there is no token renewal and the old token is kept. This small modification corrects this problem.
SGrueber
approved these changes
Jun 28, 2023
|
@tbouliere-datasolution We experienced also a different error message, if the token is invalid, that's why we generalized the condition a bit. Is the fix ok for you as it is now? |
|
@SGrueber Yes it is working without side effect on our side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of local development, you can change the target back-end by modifying the value of the
icmBaseURLvariable inenvironment.developement.ts. By doing so, you will need a new api token.However, as your local DNS is still "localhost", there is no token renewal and the old token is kept.
This small modification corrects this problem.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Issue Number: Closes #
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information