Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom response headers with NGINX #1456

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented Jul 4, 2023

PR Type

[x] Feature

What Is the Current Behavior?

A new environment variable ADDITIONAL_HEADERS is introduced for the nginx deployment to dynamically add custom headers to response request to the client.

example for docker-compose.yml:

   nginx:
    build: nginx
    environment:
      ADDITIONAL_HEADERS: |
        headers:
          - X-Frame-Options: 'SAMEORIGIN'
          - X-Content-Type-Options: 'nosniff'

example for Helm values.yml:

  cache:
    extraEnvVars:
       - name: ADDITIONAL_HEADERS
         value: |
            headers:
              - X-Frame-Options: 'SAMEORIGIN'
              - X-Content-Type-Options: 'nosniff'

What Is the New Behavior?

Does this PR Introduce a Breaking Change?

[ x ] No

Other Information

AB#87490

@Eisie96 Eisie96 requested review from shauke and removed request for shauke July 4, 2023 12:56
@shauke shauke changed the title Feat/nginx add header feat: add custom headers with NGINX Jul 5, 2023
@shauke shauke changed the title feat: add custom headers with NGINX feat: add custom response headers with NGINX Jul 5, 2023
@Eisie96 Eisie96 marked this pull request as ready for review July 7, 2023 08:22
@Eisie96 Eisie96 assigned shauke and unassigned Eisie96 Oct 19, 2023
@shauke shauke added this to the 5.0 milestone Nov 8, 2023
@shauke shauke merged commit 28268d8 into develop Nov 30, 2023
20 of 21 checks passed
@shauke shauke deleted the feat/nginx-add-header branch November 30, 2023 07:53
shauke pushed a commit to intershop/helm-charts that referenced this pull request Nov 30, 2023
shauke pushed a commit to intershop/helm-charts that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants