fix: handle multitab browsing #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
requested changes
Aug 7, 2023
Eisie96
force-pushed
the
fix/multitab-session
branch
2 times, most recently
from
5ba5c16
to
452f406
Compare
Eisie96
force-pushed
the
fix/multitab-session
branch
from
452f406
to
e2086ef
Compare
When browsing the site using different tabs, the identification status is not well persisted across tabs. This is particularly annoying when a user opens several tabs to compare products before adding them to the shopping cart. The following fix corrects these problems
SGrueber
force-pushed
the
fix/multitab-session
branch
from
270cebd
to
80153d9
Compare
Eisie96
approved these changes
Sep 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing the site using different tabs, the identification status is not well persisted across tabs.
This is particularly annoying when a user opens several tabs to compare products before adding them to the shopping cart.
The following fix corrects these problems
PR Type
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Step to reproduce the bug
Issue Number: Closes #
What Is the New Behavior?
When an anonymous or user token is created on one tab, the change is propagated to the other tab within a second.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information