Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display first product image after switching products #1474

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Aug 8, 2023

...on product detail page

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

When switching between product detail pages in the PWA ( e.g. via the Recently Viewed list), it may happen that instead of the primary product image (the first one), another one of the available product images is displayed. This depends on which product image was displayed on the previous PDP (e.g. if the second image of Product A was displayed, the second product image of Product B will be displayed after opening the PDP of Product B).

Issue Number: Closes #

What Is the New Behavior?

After changing the product on product detail page always the first product image is shown.

Does this PR Introduce a Breaking Change?

##Steps to repeat

  1. open the PWA
  2. open the PDP of any product (e.g. 859910)
  3. open the PDP of another product (e.g. 201807232)
  4. select product image 2 via thumbnail click or arrow buttons
  5. open the PDP of the product from step 2 via "Recently Viewed" list
    --> product image 2 of this product is displayed instead of 1

[ ] Yes
[x] No

Other Information

AB#88377
AB#88311

@SGrueber SGrueber self-assigned this Aug 8, 2023
@SGrueber SGrueber added this to the 4.2 milestone Aug 8, 2023
@shauke shauke merged commit 96737be into develop Aug 11, 2023
@shauke shauke deleted the bugfix/display_first_product_image branch August 11, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants