feat: implement better handling for cookie 'SameSite' and 'secure' settings #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
force-pushed
the
feature/cookie_handling_defaults
branch
from
5ee0522
to
a39545c
Compare
SGrueber
requested changes
Aug 28, 2023
shauke
added a commit
that referenced
this pull request
Aug 28, 2023
…ttings (#1485) * defaults to 'SameSite=Strict' and 'secure' if not explicitly set to other values * sets all cookies with 'SameSite=None' if run within an iframe * if run with 'http' (should only be in development environments) 'secure' is not set * inspired by https://medium.com/trabe/cookies-and-iframes-f7cca58b3b9e BREAKING CHANGES: The `cookies.service` has new defaults: `SameSite=Strict` and `secure` (see [Migrations / 4.1 to 4.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#41-to-42) for more details).
shauke
added a commit
that referenced
this pull request
Aug 28, 2023
shauke
force-pushed
the
feature/cookie_handling_defaults
branch
from
a39545c
to
ca823a0
Compare
SGrueber
added
enhancement
shauke
added a commit
that referenced
this pull request
Sep 4, 2023
…ttings (#1485) * defaults to 'SameSite=Strict' and 'secure' if not explicitly set to other values * sets all cookies with 'SameSite=None' if run within an iframe * if run with 'http' (should only be in development environments) 'secure' is not set * inspired by https://medium.com/trabe/cookies-and-iframes-f7cca58b3b9e BREAKING CHANGES: The `cookies.service` has new defaults: `SameSite=Strict` and `secure` (see [Migrations / 4.1 to 4.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#41-to-42) for more details).
* macOS 11 with Safari 14 seems to not handle 'SameSite=Strict' cookies (e.g. when redirecting to the payment provider page) correctly * the 'apiToken' cookie that handles the authentication (logged in user) state is no longer present so that the order cannot be fetched and displayed again * fix would be to not write 'SameSite=Strict' cookies in Safari 14 * the simple browser detection could be replaced if a more sophisticated version is needed
* was missing for "accept only essential"
shauke
force-pushed
the
feature/cookie_handling_defaults
branch
from
493868a
to
240ed99
Compare
SGrueber
approved these changes
Sep 6, 2023
shauke
added a commit
that referenced
this pull request
Sep 6, 2023
…ttings (#1485) * defaults to 'SameSite=Strict' and 'secure' if not explicitly set to other values * sets all cookies with 'SameSite=None' if run within an iframe * if run with 'http' (should only be in development environments) 'secure' is not set * inspired by https://medium.com/trabe/cookies-and-iframes-f7cca58b3b9e BREAKING CHANGES: The `cookies.service` has new defaults: `SameSite=Strict` and `secure` (see [Migrations / 4.1 to 4.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#41-to-42) for more details).
shauke
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the New Behavior?
feat: implement better handling for cookie 'SameSite' and 'secure' settings
Does this PR Introduce a Breaking Change?
[x] Yes
The
cookies.servicehas new defaults:SameSite=Strictandsecure(see Migrations / 4.1 to 4.2 for more details).Other Information
AB#88753