fix: remove api-token cookie just for created '/' path #1487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The api-token needs to be removed, when the user logs out succesfully. It's not working in a multi-site PWA setup with a custom configured
baseHref
property (e.g. /en). The usedcookieService.remove(key)
method, to remove the apiToken, overwrites the cookie property from the window with the valueapiToken=;path=/en;expires=Thu, 01 Jan 1970 00:00:00 GMT
. The created path (e.g. '/en') differs with the initial path property from the apiToken ('/'). With the SameSite=Strict the browser doesn't allow to remove the cookie.Issue Number: Closes #
What Is the New Behavior?
An option parameter is added to the
cookieService.remove(key)
method to allow custom options to remove cookies. With that it is possible to overwrite the path property from the generated cookie value.Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information
AB#88773